Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed server starting in venv, and not system-wide #114

Closed
wants to merge 1 commit into from
Closed

fixed server starting in venv, and not system-wide #114

wants to merge 1 commit into from

Conversation

Kortho
Copy link
Contributor

@Kortho Kortho commented Jul 2, 2019

server.py was started with system-wide python env. source makes it run in venv

server.py was started with system-wide python env. source makes it run in venv
@mokaddem mokaddem added signed-off:mokaddem Acknowledged by mokaddem and removed signed-off:mokaddem Acknowledged by mokaddem labels Jul 2, 2019
@mokaddem
Copy link
Contributor

mokaddem commented Jul 2, 2019

I'm not sure this is the correct way to do it.
IMHO, you should be in an virtualenv before starting start_all.sh

@Kortho
Copy link
Contributor Author

Kortho commented Jul 2, 2019

sort of agree, but if so, it should be "python3 ${DIR}/server.py &"
And all the stuff with venv could just be removed. By doing it this way, the code works, and the user does not have to worry about it at all (make it easier to be more secure for the user)

@Kortho Kortho closed this Jul 5, 2019
@Kortho Kortho deleted the patch-3 branch July 5, 2019 11:37
@Kortho Kortho mentioned this pull request Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants