Allow hyphens in segment names, and fix basic parsing issues #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 31, 2021 15:01
When reading a header file, each line is parsed by matching it against a regular expression. Previously, this was done by searching for the pattern *anywhere* in the input line (using findall()) rather than at the start of the line (using match()). In particular, if the first token on the line (e.g., a signal file name or segment name) contains a disallowed character, this must be treated as an error, rather than silently ignoring everything up to and including the disallowed character. Note, however, that horizontal whitespace is permitted at the start of the line, so the expressions must begin with "[ \t]*".
|
thanks Benjamin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyphens should be permitted in segment names. Currently hyphens are permitted in record names and signal file names, but not in segment names.
When parsing a line in a header file, we must start at the beginning of the line. Currently we search for the expected pattern anywhere within the line, which means any "junk" at the start of the line is silently ignored.
This means that if a multi-segment record includes a segment with a hyphen in the name, everything up to and including the hyphen is silently ignored.
A related problem occurs if there are slashes in a segment or signal file name. Although subdirectories are permitted in WFDB format, wfdb-python currently doesn't support them, so these should raise an exception rather than being silently ignored.