Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DSpace submit functionality #13

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Add DSpace submit functionality #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ee21b5
Add DSpace submit functionality
hakbailey Sep 15, 2021
c7822e0
Update error result message to match ADR
hakbailey Sep 16, 2021
6255aa4
Minor changes based on PR feedback
hakbailey Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,3 +127,5 @@ dmypy.json

# Pyre type checker
.pyre/

.DS_Store
2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ ENV PIP_NO_CACHE_DIR yes
WORKDIR /app
RUN pip install --no-cache-dir --upgrade pip pipenv

RUN apt-get update && apt-get upgrade -y && apt-get install -y git

COPY Pipfile* /
RUN pipenv install --system --clear --deploy

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ isort: ## isort your imports, so you don't have to
pipenv run isort . --diff

test: ## runs pytest
pipenv run pytest
pipenv run pytest --cov=submitter

coveralls: test
pipenv run coveralls
6 changes: 6 additions & 0 deletions Pipfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ name = "pypi"
[packages]
click = "*"
boto3 = "*"
smart-open = "*"
dspace-python-client = {ref = "0.1.0", git = "https://github.com/mitlibraries/dspace-python-client.git"}

[dev-packages]
flake8 = "*"
Expand All @@ -15,6 +17,10 @@ bandit = "*"
moto = {extras = ["s3", "sqs"], version = "*"}
pytest = "*"
coveralls = "*"
requests-mock = "*"
pytest-cov = "*"
pytest-env = "*"
freezegun = "*"

[requires]
python_version = "3.9"
Expand Down
112 changes: 83 additions & 29 deletions Pipfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ make dist
docker run submitter:latest --
```

note: the application requires being run in an environment with Roles based access to the AWS resources.
note: the application requires being run in an environment with Roles based access to the AWS resources. in addition, the environment must have WORKSPACE and SSM_PATH variables set according to stage and prod conventions.
Loading