Skip to content

Conversation

cabutlermit
Copy link
Contributor

@cabutlermit cabutlermit commented Sep 10, 2025

Why these changes are being introduced:

How this addresses that need:

Relevant ticket(s):

Purpose and background context

The first pass at the automated deployment workflows.

  • Edit one line in the Dockerfile to get ride of a warning
  • Update the Makefile with a modified version of the output from mitlib-tf-workloads-ecr
  • Create the dev, stage, and prod workflows with some modifications to the outputs from mitlib-tf-workloads-ecr

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

Code review

  • Code review best practices are documented here and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

Why these changes are being introduced:
The first pass at the automated deployment workflows.

How this addresses that need:
* Edit one line in the Dockerfile to get ride of a warning
* Update the Makefile with a modified version of the output from
mitlib-tf-workloads-ecr
* Create the dev, stage, and prod workflows with some modifications to
the outputs from mitlib-tf-workloads-ecr

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1446
@coveralls
Copy link

coveralls commented Sep 10, 2025

Pull Request Test Coverage Report for Build 17653824094

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 17586703946: 0.0%
Covered Lines: 35
Relevant Lines: 35

💛 - Coveralls

@cabutlermit cabutlermit merged commit 277f67b into main Sep 11, 2025
3 checks passed
@cabutlermit cabutlermit deleted the ecr-workflows branch September 11, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants