Remove bounding box requirement from MITAardvark and validate when present #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * This enables Geo-Harvester to process geospatial metadata with missing or potentially invalid geospatial bounding box information. This change is in preparation of the ingestion of geospatial metadata from external sources that will likely vary in data quality. Having these fields as required may be too restrictive. How this addresses that need: * Remove bounding box fields as 'required' from MITAardvark JSON schema * Remove bounding box fields from test fixtures representing 'required' data * Move bounding box attributes to 'optional' group in harvester.records.MITAardvark Side effects of this change: * Required follow-up work: Geo-Harvester will validate bounding box information when present. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/GDT-159
jonavellecuerdo
force-pushed
the
GDT-159-make-bbox-optional-and-add-quality-validation
branch
from
55cc2d7
to
c98d973
Compare
jonavellecuerdo
deleted the
GDT-159-make-bbox-optional-and-add-quality-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
TBD
How can a reviewer manually see the effects of these changes?
TBD
Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)