Remove SQS check #143
Merged
Remove SQS check #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove --skip-sqs-check click option from CLI * Remove MITHarvester._sqs_queue_is_empty method and call in full_harvest_get_source_records method * Remove test_mit_harvester_full_harvest_non_empty_sqs_queue_raise_error
ghukill
requested changes
Feb 7, 2024
There was a problem hiding this comment.
Looks good! Cutting is delivering.
One request: to remove this bit from the README here: https://github.com/MITLibraries/geo-harvester/blob/GDT-170-remove-sqs-check/README.md?plain=1#L128-L129.
Otherwise, with that, approved! Thanks for thinking this one through.
* Remove --skip-sqs-reference from README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Per GDT-170, @ghukill and I agreed that was no need for the SQS queue check when running a full harvest and that any adverse consequences are unlikely and would be handled by existing functionality in
transmogrifierandtimdex-index-manager.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)