Handle missing source record for logging #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Fix small bug where missing
Record.source_record
results in logging failure during harvest pipelineget_source_records()
step.Now that
get_source_records()
can return aRecord
without an attachedSourceRecord
, we need to skip logging details from the source record if not present in this step.Error before fix:
Success after fix, showing problematic record marked as "failed" but process continues:
How can a reviewer manually see the effects of these changes?
Change is very minor; logic should be understandable from the change.
But if interested in running, currently one problematic message in SQS queue. Can run incremental MIT harvest:
Env vars:
command (that preserves the SQS message):
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)