Bug Fix: Same Filename Different Extensions #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: During the first full test with stakeholders, an issue came up with files that had the same stem but different extensions and this caused an issue copying files. See #36. How this addresses that need: * Change the way the NAS subfolder is named to use the full filename and not just the stem * Update the tests to reflect this new way of creating the "clean" NAS subfolder name Side effects of this change: None. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IR-214 Resolves #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
See #36 and the comment thread on IR-214. This fixes the bug raised in that issue.
How can a reviewer manually see the effects of these changes?
Joe Carrano has already run the code from the bug fix branch and verified that it resolved the issue. See is comment on IR-214.
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)