Quickfix for database connection #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Why are these changes being introduced: * We need to identify workflows for developers to use to build on this platform, and document them in the project readme. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/engx-201 ** How does this address that need: * The primary outcome of this work is an updated set of documentation in the project readme, describing many commonly-used workflows (creating new applications, copying content between applications, etc). * The documentation also identifies required tools that developers will need to contribute to this project, as well as relevant requirements for things like git branch names. * As proof of these workflows, this also adds two types of code: 1. A community-written plugin (Classic Editor) 2. A locally-written plugin (our plugin canary), including the update to the gitignore file which allows it. * This adds an updated pull request template for future use here. Please note that I made some changes from the template we use in other projects. ** Document any side effects to this change: * The biggest one is probably the use of a non-standard PR template.
* Confirming and documenting a local development workflow is a key deliverable for evaluating Pantheon ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ENGX-202 ** How does this address that need: * Adds lando configuration based on pantheon recipe * Updates application configuration to allow using lando in our local environment * Documents developer workflow for creating pulling data and files from pantheon ** Document any side effects to this change: * Mentions of localdev have been removed now that we are planning to use lando Co-Authored-By: Jeremy Prevost <jprevost@mit.edu>
|
This is the wrong merge proposall, closing. |
matt-bernhardt
added a commit
that referenced
this pull request
Apr 19, 2023
** Why are these changes being introduced: * Attempting to load the map template right now generates the following error message in the logs: PHP Fatal error: Uncaught ValueError: array_rand(): Argument #1 ($array) cannot be empty in /app/web/app/themes/mitlib-parent/templates/page-map-locations.php:63 ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-306 ** How does this address that need: * The problem appears to be that the page template doesn't anticipate a condition in which no images are associated with a location record? Which is odd, as there _are_ records in the legacy system which do not have images. Regardless, the Courtyard Cafe record is definitely breaking the map template because the $arMain array in this template ends up being empty. * This changes how this array is handled, only grabbing a random item from $arMain if there is at least one element in the array. Otherwise the default value of '' (now assigned at the start of these lines) is left unchanged. ** Document any side effects to this change: * This template is a pit of vipers, lying in wait for an unsuspecting developer. I barely escaped with my life.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest, I'm not sure why this is working - but it is. If you check the
quickfixreview application you'll see that it can communicate with its database.Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES | NO dependencies are updated
Code Reviewer
(not just this pull request message)