Remove polyfill from hours plugin #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm putting this into code review now to expedite the process, but am also checking with Darcy about whether anyone in UX wants to take a look at this before it merges. I've checked the hours displays that we're using, and confirmed that they're all still loading information:
|
** Why are these changes being introduced: * The javascript used by our hours intergration had used Polyfill as part of its architecture, going back many years. Unfortunately that has been the subject of a supply chain attack, and needs to be removed. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/pw-99 ** How does this address that need: * This removes the Polyfill library from our hours library, which prevents anyone from loading the compromised script. ** Document any side effects to this change: * None - testing shows that the front end hours displays are all still functioning. The administrative process of refreshing the local cache is written in PHP, so it shouldn't be affected by this change.
JPrevost
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the Polyfill javascript library from our hours plugin, and updates the Sentry plugin which also could have loaded the script which is now subject to a supply chain attack.
Confirmation that this works should be that you no longer see the network loading a script from the compromised domain.
Developer
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES dependencies are updated
Code Reviewer
https://mitlibraries.atlassian.net/browse/PW-99
(not just this pull request message)