Skip to content

Conversation

djanelle-mit
Copy link

@djanelle-mit djanelle-mit commented Oct 11, 2024

The Research & Guides section of the homepage had fake counts hardcoded into the template. UX asked to remove these counts and change the language to "All guides" and "All experts".

Relevant ticket(s):
PW-105 - https://mitlibraries.atlassian.net/browse/PW-105

How does this address that need:
This PR removes the fake counts and keeps the button text "All x" instead of "All [count] x".

Document any side effects to this change:
None expected.

Developer

Stylesheets

  • Any theme or plugin whose stylesheets have changed has had its version
    string incremented.

Secrets

  • All new secrets have been added to Pantheon tiers
  • Relevant secrets have been updated in Github Actions
  • All new secrets documented in README

Documentation

  • Project documentation has been updated
  • No documentation changes are needed

Accessibility

  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)

Stakeholder approval

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies

YES | NO dependencies are updated

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • The changes have been verified
  • The documentation has been updated or is unnecessary
  • New dependencies are appropriate or there were no changes

Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and can merge as-is. There is one more bit of code that should be removed, but leaving it in place doesn't seem to cause any problems:

https://github.com/MITLibraries/mitlib-wp-network/blob/master/web/app/themes/mitlib-parent/js/experts-home.js#L79-L80

It is up to you whether you want to remove that now, or leave it for later cleanup. If you leave it in place, I'll create a ticket in the backlog to remove it during regular maintenance.

@djanelle-mit
Copy link
Author

@matt-bernhardt Not sure if this needs review again, but noting that I decided to remove the js line now, seemed silly to keep it around.

@matt-bernhardt
Copy link
Member

We don't have Github configured to clear old reviews when new commits get pushed (we could adopt that in the future, but haven't so far). Doing what you've done here, tagging the reviewer and talking about what's going on, has been our practice - so good job there :-)

I'm fine with this merging - since you've taken out those JS lines, we won't need a future ticket.

@djanelle-mit djanelle-mit merged commit d29f062 into master Oct 16, 2024
3 checks passed
@djanelle-mit djanelle-mit deleted the pw-105 branch October 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants