Remove the WP Slug Trimmer plugin #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
The WP Slug Trimmer plugin, one of our abandoned plugins which is deployed via a private repository, has a bug that prevents it from functioning on PHP 8. In digging a bit deeper in the legacy site, it may not be functioning there either (although it also does not throw errors and break the site like it does under PHP 8).
Our choices, as laid out in LM-287, are to either take ownership over the plugin and fix the bug (and then investigate whether it actually works), or to retire the plugin entirely.
Relevant ticket(s):
How does this address that need:
How to confirm this change
Log into the Live tier on Pantheon, go to the News dashboard, and try to publish a Post (just a title and body field are needed, not all the other fields). Note that the application crashes.
Additionally, try to load the Settings page for Slug Trimmer (Settings -> Slug Trimmer). Note that this page also crashes.
Log into the review app for this PR. Note that Slug Trimmer is no longer on the list of available plugins. Publish a Post (same restrictions, just a title and body field). Note that the Post is created successfully.
Document any side effects to this change:
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES dependencies are updated
Code Reviewer
(not just this pull request message)