Remove unneeded page templates from News theme #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Why are these changes being introduced: * In conversation with Darcy, we've identified three templates in the News theme that are no longer needed. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-297 ** How does this address that need: * This removes the three templates which we've agreed are no longer needed: * Subscribe * Last Year Archive * Test ** Document any side effects to this change: * None
|
I pulled this PR back from code review because I realized that I missed a related step. Second commit coming... |
** Why are these changes being introduced: * The Parent theme defines a number of page templates which are only needed by the parent site, and which end up cluttering the template picker for descendant themes. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-297 ** How does this address that need: * This implements the same filter which we introduced in the Child theme to remove unneeded inherited templates. We allow the Style Guide template to remain, on the off chance that we'll need such a page on the News site. ** Document any side effects to this change: * This also introduces the block comment in functions.php which separates "things that get called automatically" from "functions which may be called elsewhere in the theme". That division should help us to keep the file somewhat organized during future development.
JPrevost
approved these changes
Mar 31, 2023
matt-bernhardt
pushed a commit
that referenced
this pull request
May 10, 2023
#79) 78: Force symbolic links in composer (no clone/embed folders).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the three page templates which Darcy indicated were no longer needed.
Developer
https://mitlibraries.atlassian.net/browse/LM-297
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)