Fix news theme sidebars #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Why are these changes being introduced: * The News theme templates refer to a "subscribe" sidebar, rather than properly receiving sidebars defined in the Parent theme. * Additionally, some sidebars from the Parent theme are not relevant for this theme, and should be removed to prevent accidental use. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-296 ** How does this address that need: * This takes the approach of unregistering sidebars, which we already use in the Child theme, and implements it (via functions.php) for the News theme. We unregister inherited sidebars that are not needed, leaving only "sidebar-1" and "sidebar-404" (the migrated content area) * The sidebar.php partial, which references the "subscribe" sidebar, is updated to refer instead to "sidebar-1" ** Document any side effects to this change: * The indenting on the sidebar partial is also reduced, and some extra whitespace removed.
JPrevost
approved these changes
Mar 31, 2023
matt-bernhardt
pushed a commit
that referenced
this pull request
May 10, 2023
* 72:Sage theme script adjustment for invalid theme names. * 72 tweak: More cross-language space checking. * Simplify the tr and add underscore handling and additional error checking This adds the tr command that converts characters to lowercase and the underscore handling and adds some additional optimizations and error handling. * checks for double-dashes -- this happens if you pass a string with both a space and an underscore (e.g. `this string is _really_ broken`) * checks for and strips a trailing dash -- not entirely sure where this was coming from, but when I passed strings in, they always ended with a trailing `-`. This strips that out if it exists. This was the result of passing the original code and the suggested code (for underscores and caps) through ChatGPT and asking it to optimize it for me. --------- Co-authored-by: Chris Reynolds <chris.reynolds@pantheon.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves how the News theme handles sidebars, and makes this a viable feature once the content is imported.
https://mitlibraries.atlassian.net/browse/LM-296
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)