News site updates based on internal review #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Why are these changes being introduced: * There is currently a confusing overlap between a content type and a category applied to that content type - both being named "Bibliotech" in some cases. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-300 ** How does this address that need: * This updates the name of the category applied to the Bibliotech post type to be "Bibliotech Issues", to prevent the confusion. ** Document any side effects to this change: * None
** Why are these changes being introduced: * The news theme makes reference to a few named image sizes which are not yet defined in the theme's functions.php file. This gap means that content editors are not constrained to the proper dimensions when they assign images to those fields which use the missing sizes. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-300 ** How does this address that need: * This adds the definitions for the image sizes to the news theme's functions.php. ** Document any side effects to this change: * None
** Why are these changes being introduced: * There are two sets of custom fields which are not loading correctly. One is due to a name collision, as two JSON files have identical names. The other is because of invalid JSON. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-300 ** How does this address that need: * The two sets of field definisions which share a name are updated to use the "-1" and "-2" suffixes, like we use in other cases. * The invalid JSON is corrected in another field definition. ** Document any side effects to this change: * None (although I now want to identify a CLI tool that can be run by Composer in GitHub Actions to guard against this).
JPrevost
approved these changes
Apr 5, 2023
matt-bernhardt
pushed a commit
that referenced
this pull request
May 10, 2023
74:Setting script PHP version properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the problems identified during a close review of the needed workflows in the News site. Specically, each of the following changes are made in one commit each:
Ticket
https://mitlibraries.atlassian.net/browse/LM-300
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)