Add Interview and Interviewees post type, and Interview page template #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-bernhardt
changed the title
|
A quick postscript about CodeClimate. Four of the five flags are in the "thanks, we need to tune your operations better" category (code repetition flagging block comments? really?) The fifth, about some whitespace in the interview template, will get resolved when we completely rebuild that template as part of LM-331. |
** Why are these changes being introduced: * The application needs content types for Interview and Interviewee records, in order to support content from the Music Oral History site. * Those post types need to be built in the same approach that we used for other post types, such as the Bibliotech articles, Location and Expert records, or Exhibits. * The legacy site used a different set of plugins to achieve this purpose, but we believe that this will not pose an insurmountable problem. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-298 ** How does this address that need: * This adds locally-written plugins that add post types for Interview and Interviewee records. Each has its own plugin, with fields defined by a JSON file inside the Mitlib Post plugin's data folder. * The Child them also gets a new page template to minimally render the Interview post type. This will need to be built out more fully as part of LM-331 - right now it just shows a handful of fields in a table display, while the legacy MOH theme has a much more complex structure. * The Interviewee post type does not have its own display - these records are instead shown in context by the Interview post type. ** Document any side effects to this change: * There should be no side effects, but I wanted to note that the fields here were originally defined by plugins which we are retiring - TablePress was used for some repeating values, while Toolset Types was originally used to define most of the fields.
** Why are these changes being introduced: * The Tablepress plugin is no longer needed by this application, as the only content it managed (some tabular data that was part of the Music Oral History site) is being moved into ACF-managed repeater fields. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-298 ** How does this address that need: * This removes TablePress. No other changes are needed, as the Pantheon application has not yet had any content imported into TablePress. ** Document any side effects to this change: * None
** Why are these changes being introduced: * The Music Oral History site on the network is being imported to this application in such a way that it will be rendered using the Child theme, so the stubbed "mitlib-moh" theme which we'd started to define will no longer be needed. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-298 ** How does this address that need: * This removes the mitlib-moh theme. ** Document any side effects to this change: * None
JPrevost
approved these changes
Apr 13, 2023
matt-bernhardt
pushed a commit
that referenced
this pull request
May 10, 2023
* create a new function to check jq if jq doesn't exist, look for brew or apt-get. if neither of those exist, exit hard. * update the command * [BUGS-6035] Adding upstream .lando file for installation of 'jq', 'npm', etc. (#83) 73:Adding upstream .lando file for installation of 'jq', 'npm', etc. * add link to jq downloads page * require shellcheck this might mean we need to tweak some of the gh actions to ensure shellcheck is installed there, we'll see if this fails... * update the composer scripts & add the lint script * suggest installing jq manually * ignore shellcheck unused vars for colors * shellcheck linting suggestiosn * actually lint * comment out color/style variables we aren't using * replace == with -eq * switch back to == because it's required * switch -eq back to == * use fewer conditionals bail early and often if we've met our conditions Co-authored-by: Phil Tyler <philip@tylerdigital.com> --------- Co-authored-by: Charles Leverington <charles.leverington@gmail.com> Co-authored-by: Phil Tyler <philip@tylerdigital.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more-polished set of changes to support the path we've identified for the Music Oral History resource. Specific changes include:
Details of each of the above items can be found in each of the three commits on this branch.
This work is also supported by a review app I've prepared, which is described in more detail in the linked Jira ticket, to show what becomes possible based on this proposed change. I'd recommend reading the latest comment on that ticket for information about the content-side changes that I took as part of that.
Relevant ticket(s):
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES dependencies are updated (a third-party plugin is removed)
Code Reviewer
(not just this pull request message)