Skip to content

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented Apr 11, 2023

Relevant ticket(s):

How does this address that need:

  • Removes the two links

Document any side effects to this change:

  • A css rule was updated to keep similar sizing when moving from 5 to 3 elements in the flexbox. The rails apps did not need this, but since they use a different grid altogether this may not be unexpected.

Developer

Secrets

  • All new secrets have been added to Pantheon tiers
  • Relevant secrets have been updated in Github Actions
  • All new secrets documented in README

Documentation

  • Project documentation has been updated
  • No documentation changes are needed

Accessibility

  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)

Stakeholder approval

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies

NO dependencies are updated

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • The changes have been verified
  • The documentation has been updated or is unnecessary
  • New dependencies are appropriate or there were no changes

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/UXWS-1511

How does this address that need:

* Removes the two links

Document any side effects to this change:

* A css rule was updated to keep similar sizing when moving from 5 to 3
  elements in the flexbox. The rails apps did not need this, but since
  they use a different grid altogether this may not be unexpected.
@JPrevost JPrevost requested a review from matt-bernhardt April 11, 2023 14:24
@matt-bernhardt matt-bernhardt self-assigned this Apr 11, 2023
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty straightforward. I'm still trying to wrap my head around why the CSS change is necessary, but am not going to argue that it works. I kind of hate the whole way that this "identity" div behaves, but that's not the point of this work.

@JPrevost JPrevost merged commit fdca08a into master Apr 11, 2023
@JPrevost JPrevost deleted the uxws-1511 branch April 11, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants