Updates 404 page content #86
Conversation
|
I'll fix those two code climate whitespace issues. [done] |
There was a problem hiding this comment.
LGTM - I've not read the Jira ticket closely to confirm that the content here is correct, but have faith that the folks in UX have their eyes on that.
Good call on adding a sample URL to the search template, should future-us want to confirm where that gets called (or doesn't).
| <p>You can also check out these commonly-used resources:</p> | ||
| <p>Need help? <a href="/ask">Ask us!</a></p> | ||
|
|
||
| Or try: |
There was a problem hiding this comment.
Hmm, interesting - I was going to ask that this text be enclosed in a tag, but the W3C validator doesn't flag it as a problem. So nevermind :-)
There was a problem hiding this comment.
I think it's probably part of a div at some point so it's technically fine. However, I'm glad you pointed it out as now it's bugging me and I suspect I'll throw it in a
if it doesn't muck up the display too much.
There was a problem hiding this comment.
I've wrapped it in a
tag and it looks fine to me. I'm holding off on merging this until UX signs off. Thanks!
Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/LM-270 How does this address that need: * Updates markup to match requested changes in linked ticket Document any side effects to this change: The 404 template and the default search results template both share the same search form partial. We don't generally expect the default search template to be used, but the changes to 404 do cause that to update as well.
carves out an exception to the index.php file in post install Our post-install command was updated to create hard symlinks to the contents of the web/wp directory. We do not want this for the index.php file which is modified to point to /wp/
2 participants
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
The 404 template and the default search results template both share the same search form partial. We don't generally expect the default search template to be used, but the changes to 404 do cause that to update as well.
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)