Adds styles specific to 2021 location template #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPrevost
approved these changes
Apr 24, 2023
** Why are these changes being introduced: * The set of parent theme styles was apparently created without those which apply to the 2021 location template. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-305 ** How does this address that need: * This brings up the block of styles for that template. ** Document any side effects to this change: * None for this change, but I'm trying to understand how these styles (and some other more recent changes to the theme) were missed during the initial theme build-out. I wonder whether my copy of the parent theme was somehow behind the main branch at the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
The set of parent theme styles was apparently created without those which apply to the 2021 location template.
Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/lm-305
How does this address that need:
This brings up the block of styles for that template.
Document any side effects to this change:
None for this change, but I'm trying to understand how these styles (and some other more recent changes to the theme) were missed during the initial theme build-out. I wonder whether my copy of the parent theme was somehow behind the main branch at the time.
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)