Skip to content

Conversation

matt-bernhardt
Copy link
Member

@matt-bernhardt matt-bernhardt commented Apr 26, 2023

This refactors how event times are processed during import. The legacy approach (used on both the legacy AWS infrastructure as well as the Pantheon/Lando containers) relied on a WordPress-focused approach. While that worked on our AWS environment, it didn't have the same results in Pantheon/Lando.

As an alternative, this change focuses on a PHP-centric approach to time calculations - which I suspect is working because it doesn't rely on the container itself being set to any particular timezone.

Developer

Secrets

  • No secrets are affected

Documentation

  • No documentation changes are needed

Accessibility

  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)

Stakeholder approval

  • Stakeholder approval has been confirmed

Dependencies

NO dependencies are updated

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • The changes have been verified
  • The documentation has been updated or is unnecessary
  • New dependencies are appropriate or there were no changes

Copy link
Member

@JPrevost JPrevost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't confirmed this is working, but this looks like a good approach. Approving with the assumption we can tweak it if we find edge cases where it gets weird. :shipit:

@matt-bernhardt matt-bernhardt merged commit 35bf05a into master Apr 27, 2023
@matt-bernhardt matt-bernhardt deleted the lm351 branch April 27, 2023 20:32
matt-bernhardt pushed a commit that referenced this pull request May 10, 2023
Adds syncing of default to main branch and adjusts documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants