Skip to content

Conversation

ehanson8
Copy link
Contributor

@ehanson8 ehanson8 commented Nov 7, 2023

Purpose and background context

This version of the PR template was already approved in the python-cli-template repo

How can a reviewer manually see the effects of these changes?

View this PR for an example of the updated template.

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

  • NA

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed and verified
  • New dependencies are appropriate or there were no changes

* Update pull request template based on team discussion
Copy link

github-actions bot commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6790196967

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6787441580: 0.0%
Covered Lines: 19
Relevant Lines: 19

💛 - Coveralls

@ehanson8 ehanson8 merged commit 993e05b into main Nov 15, 2023
@ehanson8 ehanson8 deleted the pr-template-update branch November 15, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants