Add sentry integration #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: We generally want Sentry integration for most apps, and its a bit different for lambda functions than for other Python apps so it's important to have an example integration in this lambda template repo. How this addresses that need: * Adds sentry_sdk dependency to Pipfile. * Adds Sentry lambda integration to my_function module. * Adds check for required WORKSPACE env in lambda_handler function. * Adds tests for new functionality. * Updates README to include instructions for setting up a Sentry project when creating a new app from this template. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-526
ehanson8
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Sentry integration example to the repo.
Includes new or updated dependencies?
YES
What are the relevant tickets?
Developer
Code Reviewer