Skip to content

Sets primary and replica shard counts #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

Sets primary and replica shard counts #181

merged 1 commit into from
Feb 17, 2023

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented Feb 16, 2023 •
edited by hakbailey
Loading

Why are these changes being introduced:

  • AWS uses a default of 5 which is larger than our current and predicted data size indicates is appropriate for any single index

Relevant ticket(s):

How does this address that need:

  • Sets the value of primary and replica shards to 1 for all indexes created via TIM by adding those values to our existing settings loader

How can a reviewer manually see the effects of these changes?

  • create a new index, then checkout the other branch that adds the display of values for primary and replica shards, then list the indexes (I wasn't sure what this work would look like or I would have combined the two PRs)

Includes new or updated dependencies?

NO

Developer

  • All new ENV is documented in README (or there is none)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

hakbailey
hakbailey approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JPrevost
Sets primary and replica shard counts
131ed32 
Why are these changes being introduced:

* AWS uses a default of 5 which is larger than our current and predicted
  data size indicates is appropriate for any single index

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/TIMX-187

How does this address that need:

* Sets the value of primary and replica shards to 1 for all indexes
  created via TIM by adding those values to our existing settings
  loader
@JPrevost JPrevost force-pushed the TIMX-187-index-shard-settings branch from c64a12c to 131ed32 Compare February 17, 2023 14:11
@JPrevost JPrevost merged commit 7b9826e into main Feb 17, 2023
@JPrevost JPrevost deleted the TIMX-187-index-shard-settings branch February 17, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehanson8 ehanson8 Awaiting requested review from ehanson8

1 more reviewer

@hakbailey hakbailey hakbailey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JPrevost @hakbailey