Stop indexing for unexpected errors #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Python version * Update OpenSearch Docker image in README * Minor configuration updates * Bump boto3 from 1.26.66 to 1.26.83 * Bump opensearch-py from 2.1.1 to 2.2.0 * Bump sentry-sdk from 1.15.0 to 1.16.0 * Bump mypy from 1.0.0 to 1.0.1 * Bump pydocstyle from 6.1.1 to 6.3.0
Why these changes are being introduced: Previously when bulk-indexing returned an error from Opensearch, we logged the error, skipped the record, and continued indexing. We still want to do that for the known error around mapper parsing (since that is a data quality/transformation issue, not an Opensearch issue) but for all other errors we want to stop the process with an exception for further investigation. How this addresses that need: * Adds BulkIndexingError to errors module. * During bulk indexing, checks for the known error we want to skip and otherwise raises the new exception. * Updates tests and fixtures to reflect changes. * Minor documentation update in cli module. Side effects of this change: If we hit any errors other than the occasional expected mapping error, the Step Function will fail. This is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates bulk-indexing to skip error responses only for the known mapper parsing error, and otherwise raise an exception that stops the process. Also updates dependencies and config.
Helpful background context
We were getting some errors indicating a problem within OpenSearch, and in cases like that we don't want to continue indexing as though nothing is wrong.
Includes new or updated dependencies?
YES
What are the relevant tickets?
Developer
Code Reviewer