GDT-211-publishers-mapping #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * Implement ADR # 3 for timdex-index-manager after transmogrifier has been updated How this addresses that need: * Add publishers field to opensearch_mappings.json * Remove publication_information field Side effects of this change: * Reindexing required for new field mapping Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/GDT-211
Pull Request Test Coverage Report for Build 8238204140Details
💛 - Coveralls |
ghukill
reviewed
Mar 11, 2024
Comment on lines
+331
to
+334
| "date": { | ||
| "type": "keyword", | ||
| "normalizer": "lowercase" | ||
| }, |
There was a problem hiding this comment.
I think this feels right, that we don't also try and parse this to a date string. Maybe we'll revisit if we extend this pattern a bit, but if we know we're already duplicating dates to Dates then this as a date field likely isn't needed. With, the benefit of handling non-normal date strings that may still contain information.
jonavellecuerdo
approved these changes
Mar 12, 2024
ghukill
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Implement ADR # 3 for timdex-index-manager after transmogrifier has been updated.
How can a reviewer manually see the effects of these changes?
Ensure that
TIMDEX_OPENSEARCH_ENDPOINTis not set as an env var and spin up a local Docker container with:In new terminal window, create a new gismit index:
Copy the index name and promote the index to the gismit alias:
Set
Dev1credentials andbulk-indexthe following S3 file withpublishersfield to see that it successfully indexes:Includes new or updated dependencies?
YES
Changes expectations for external applications?
YES
What are the relevant tickets?
Developer
Code Reviewer(s)