Rails71 app:update #125
Merged
Rails71 app:update #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All changes in these files were accepted with no changes.
We don't use ActiveStorage in this app, but app:update detected these migrations were missing so I feel it's better to add them for now. We can more fully remove ActiveStorage from this app in the future, but I was not prepared to address that during this maintenance cycle.
These files had some changes we accepted and some we kept our own configuration. Note: Updated config to force SSL in prod. This should have been set before and had an open ticket to resolve so I just made the change while touching these files. https://mitlibraries.atlassian.net/browse/GDT-207
Pull Request Test Coverage Report for Build 8087493754Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires database migrations?
YES
Includes new or updated dependencies?
YES