Skip to content

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented Apr 22, 2022

Why are these changes being introduced:

  • The data ingest and api work has started with these fields so UI is doing the same

Relevant ticket(s):

How does this address that need:

  • Display the core datacite fields if they exist for records

Document any side effects to this change:

  • Cassettes now strip out the timdex URL during generation to allow more easily using local, staging, or production timdex to generate necessary cassettes while making them look all the same so replays are consistent
  • Hardcoded "origin" has been changed to a variable. I'm not sure what we are even usign this for but instead of removing it I allowed it to be configured.
  • All tests now use v2 cassettes which required some minor changes to tests and regeneration of all cassettes
  • One test is skipped that wasn't using a cassette but looks like it thinks it was
  • The UI is still janky. We'll want to add intentional structured HTML and CSS soon.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

YES

@coveralls
Copy link

coveralls commented Apr 22, 2022

Pull Request Test Coverage Report for Build 0af5c6b40c46559462acedf3750b4fded82a8ea2-PR-33

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.6%) to 96.386%

Files with Coverage Reduction New Missed Lines %
app/models/timdex_wrapper.rb 3 85.71%
Totals Coverage Status
Change from base Build 0ad15dee0ee732d22868c8dee4aaaf7e43b026e4: -3.6%
Covered Lines: 80
Relevant Lines: 83

💛 - Coveralls

@JPrevost JPrevost force-pushed the rdi-94-core-datacite-fields branch 2 times, most recently from e624875 to 99cc5f5 Compare April 25, 2022 13:16
Why are these changes being introduced:

* The data ingest and api work has started with these fields so UI is doing the same

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/RDI-94

How does this address that need:

* Display the core datacite fields if they exist for records

Document any side effects to this change:

* Cassettes now strip out the timdex URL during generation to allow more easily using local, staging, or production timdex to generate necessary cassettes while making them look all the same so replays are consistent
* Hardcoded "origin" has been changed to a variable. I'm not sure what we are even usign this for but instead of removing it I allowed it to be configured.
* All tests now use v2 cassettes which required some minor changes to tests and regeneration of all cassettes
* One test is skipped that wasn't using a cassette but looks like it thinks it was
* The UI is still janky. We'll want to add intentional structured HTML and CSS soon.
@JPrevost JPrevost force-pushed the rdi-94-core-datacite-fields branch from 99cc5f5 to 832d419 Compare April 25, 2022 13:19
@jazairi jazairi self-assigned this Apr 25, 2022
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. :shipit: I have a couple questions about the result partial that I think would be best discussed in RDI-82.

@JPrevost JPrevost merged commit a1c70ca into main Apr 25, 2022
@JPrevost JPrevost deleted the rdi-94-core-datacite-fields branch April 25, 2022 15:42
@coveralls
Copy link

coveralls commented Nov 16, 2024

Pull Request Test Coverage Report for Build 2cc5db66830dea83548526a02f37fc245f5fcd23-PR-33

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.6%) to 96.386%

Files with Coverage Reduction New Missed Lines %
app/models/timdex_wrapper.rb 3 85.71%
Totals Coverage Status
Change from base Build 0ad15dee0ee732d22868c8dee4aaaf7e43b026e4: -3.6%
Covered Lines: 80
Relevant Lines: 83

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants