Skip to content

Conversation

ghukill
Copy link
Contributor

@ghukill ghukill commented Dec 19, 2024

Purpose and background context

This "unpins" the timdex-dataset-api (TDA) library from a specific release version, and instead builds from main.

How can a reviewer manually see the effects of these changes?

This recent run of the v2 StepFunction in Dev1 demonstrates that the TDA library installed is functional.

Note also the hash of timdex-dataset-api installed via the Pipfile.lock (e1c0c6a894b40be4f900ebc2f01ed354e2cead41). When we omit any specific references for install, and it just uses main, it gets the most recent commit (e1c0c6a894b40be4f900ebc2f01ed354e2cead41).

Includes new or updated dependencies?

YES

Changes expectations for external applications?

NO

What are the relevant tickets?

  • None

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed and verified
  • New dependencies are appropriate or there were no changes

@ghukill ghukill merged commit a8d98ab into main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants