TIMX 501 - update aspace oai identifier parsing #252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Updates the EAD transformer to handle OAI identifiers with one or two forward slashes in the identifier, e.g.:
oai:mit//repository:42
oai:mit/repository:42
Where the extracted TIMDEX identifier should be
repository:42
for both.As noted in TIMX-501, this change in the OAI output was from an ASpace 4.x upgrade, is approved by ASpace stakeholders, and will remain the output going forward. But FWIW, this regex change will handle either situation.
How can a reviewer manually see the effects of these changes?
Not much to see! This line from an EAD test confirms that, even with the new OAI identifier in the stubbed record, we get the same TIMDEX identifier.
Includes new or updated dependencies?
NO
Changes expectations for external applications?
Importantly, NO: the final
timdex_record_id
will be unchanged despite the source EAD changing its format slightlyWhat are the relevant tickets?
Developer
Code Reviewer(s)