Add Sentry #43
Add Sentry #43
Conversation
* Install sentry-sdk dependency * Add SENTRY_DSN parameter to config.py * Add function to config.py for verification of integration * https://mitlibraries.atlassian.net/browse/DLSPP-152
awd/config.py
Outdated
|
|
||
|
|
||
| def check_sentry(): | ||
| if SENTRY_DSN: |
There was a problem hiding this comment.
What is the intent behind this? If SENTRY_DSN is absent, line 71 duly reports that.
There was a problem hiding this comment.
This is called when you need to check that the actual connection to Sentry is receiving exception. It is just being stored for those situations, this is happening in the alma-scripts and dspace-submission-servicerepos as well
There was a problem hiding this comment.
It is not regularly called, it is there in for troubleshooting purposes, see the last comment here MITLibraries/alma-scripts#33
There was a problem hiding this comment.
If it is truly important to check Sentry integration, can we throw it explicitly in the smoke test or something similar?
Ideally, the program should not have any non-functional code. This is the same as having commented out code in the program. Thanks.
What does this PR do?
How can a reviewer manually see the effects of these changes?
Verify that the project has been created for our org on https://sentry.io/ and that the integration works by viewing the previously triggered exception
What are the relevant tickets?
Requires Database Migrations?
NO
Includes new or updated dependencies?
YES