Infra updates #58
Merged
Infra updates #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: The mitlib-tf-workloads-ecr infrastructure has been deployed through dev, stage, and prod. This moves all the callerworkflow updates into the app repo. How this addresses that need: * Update the dev-build workflow with minor changes from the Terraform Cloud outputs * Create the stage-build workflow for publishing to stage * Create the prod-promote workflow Side effects of this change: Merges to `main` will now trigger both the old workflow for pushing the container to our legacy AWS account and the new workflow for our AWS Organization. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-711
Why these changes are being introduced: * Further changes to complete workflow updates How this addresses that need: * Update Makefile with new ECR commands * Remove stage_ecr_push.yml Side effects of this change: * None Relevant ticket(s): * Resolves #56
cabutlermit
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mitlib-tf-workloads-ecrrepositorystage_ecr_pushworkflowMakefileHelpful background context
The build/deploy workflows in our shared .github repository for Lambda functions and Fargate tasks have been cleaned up and consolidated. The mitlib-tf-workloads-ecr repository that generates the text for the three caller workflows has been updated and we just need to move those Terraform outputs into this repository to update the caller workflows.
How can a reviewer manually see the effects of these changes?
The reviewer can view the automated run that pushed an updated container to Dev1 here:
https://github.com/MITLibraries/wiley-deposits/actions/runs/4599671023
Includes new or updated dependencies?
NO