-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge remote-tracking branch 'upstream/develop' into refactor-src-merge-develop #349
Merged
jdhughes-usgs
merged 19 commits into
MODFLOW-USGS:refactor-src
from
jdhughes-usgs:refactor-src-merge-develop
Mar 15, 2020
Merged
Merge remote-tracking branch 'upstream/develop' into refactor-src-merge-develop #349
jdhughes-usgs
merged 19 commits into
MODFLOW-USGS:refactor-src
from
jdhughes-usgs:refactor-src-merge-develop
Mar 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add traps to catch 1) skin factors that are <= 0 when using the SKIN conductance equation and 2) and negative saturated conductances values. Closes #305
Full implementation for SFR package. Partial implementation for LAK, MAW, and UZF packages.
This reverts commit 3460cfb.
* fix(lak): revise the way outlet to-mvr flows are stored in budobj * updated release notes
…d of DHNOFLO to binary file (#329) * refactor(lak/maw/sfr): for CONSTANT features write fixed value instead of DHNOFLO to binary file * update release notes
) DNODATA values reported if 1) delay interbed observations are specified and no delay interbeds are specified and 2) interbed observations are specified and the number of interbeds is zero. Added test of all observation types to test_gwf_csub_sk01.py which has no interbeds. closes #298
Modify mf5to6 to use standard SimVariables.f90 in mf6 src and add ListType variables in original mf5to6 SimVariables.f90 file to SimListVariables.f90 and update use statements.
…ge-develop # Conflicts: # autotest/simulation.py # msvs/mf6.vfproj # src/Model/GroundWaterFlow/gwf3csub8.f90 # src/Solution/NumericalSolution.f90 # src/Utilities/List.f90 # src/Utilities/Sim.f90 # src/Utilities/SimVariables.f90 # src/mf6.f90 # utils/mf5to6/src/Preproc/SimVariables.f90
…ge-develop # Conflicts: # autotest/simulation.py # msvs/mf6.vfproj # src/Model/GroundWaterFlow/gwf3csub8.f90 # src/Solution/NumericalSolution.f90 # src/Utilities/List.f90 # src/Utilities/Sim.f90 # src/Utilities/SimVariables.f90 # src/mf6.f90 # utils/mf5to6/src/Preproc/SimVariables.f90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts:
autotest/simulation.py
msvs/mf6.vfproj
src/Model/GroundWaterFlow/gwf3csub8.f90
src/Solution/NumericalSolution.f90
src/Utilities/List.f90
src/Utilities/Sim.f90
src/Utilities/SimVariables.f90
src/mf6.f90
utils/mf5to6/src/Preproc/SimVariables.f90