Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CVMix to 0.95-beta #251

Merged
merged 1 commit into from
May 30, 2019

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented May 15, 2019

This version introduces a bunch of fixes to python 3

Releases since 0.84-beta are described as:

  • v0.90-beta - Add Schmittner tidal mixing
  • v0.91-beta - Add low-level interface for Bryan-Lewis mixing
  • v0.92-beta - Fix bug in computing derivative
  • v0.93-beta - Performance enhancement
  • v0.94-beta - Update interface to Langmuir parameterization
  • v0.95-beta - Add python 3 support

closes #250

This version introduces a bunch of fixes to python 3

Releases since 0.84-beta are described as:
* v0.90-beta - Add Schmittner tidal mixing
* v0.91-beta - Add low-level interface for Bryan-Lewis mixing
* v0.92-beta - Fix bug in computing derivative
* v0.93-beta - Performance enhancement
* v0.94-beta - Update interface to Langmuir parameterization
* v0.95-beta - Add python 3 support
@xylar
Copy link
Collaborator Author

xylar commented May 15, 2019

I have verified that the code builds with gfortran and python 3.7 with this version (except that I need the BGC python 3 fix here: E3SM-Project/Ocean-BGC#1). I haven't yet tested a forward run, bit-for-bit, python 2.7 or intel compilers.

@xylar
Copy link
Collaborator Author

xylar commented May 15, 2019

No luck. I'm getting:

undefined symbol: __netcdf_MOD nf90_open

in a test I'm running. I haven't verified for sure that CVMix is the cause but it seems the most likely.

@xylar
Copy link
Collaborator Author

xylar commented May 15, 2019

Needs to wait for #134

mark-petersen added a commit that referenced this pull request May 29, 2019
This version introduces a bunch of fixes to python 3

Releases since 0.84-beta are described as:

v0.90-beta - Add Schmittner tidal mixing
v0.91-beta - Add low-level interface for Bryan-Lewis mixing
v0.92-beta - Fix bug in computing derivative
v0.93-beta - Performance enhancement
v0.94-beta - Update interface to Langmuir parameterization
v0.95-beta - Add python 3 support

closes #250
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged into ocean/develop locally. Tested on grizzly, gnu/intel, opt/debug, nightly regression suite. Passes all. Merging in.

@mark-petersen mark-petersen removed the request for review from vanroekel May 30, 2019 18:07
@mark-petersen mark-petersen merged commit 0da7f41 into MPAS-Dev:ocean/develop May 30, 2019
@xylar xylar deleted the ocean/update_cvmix branch June 14, 2019 11:15
ashwathsv pushed a commit to ashwathsv/MPAS-Model that referenced this pull request Jul 21, 2020
This version introduces a bunch of fixes to python 3

Releases since 0.84-beta are described as:

v0.90-beta - Add Schmittner tidal mixing
v0.91-beta - Add low-level interface for Bryan-Lewis mixing
v0.92-beta - Fix bug in computing derivative
v0.93-beta - Performance enhancement
v0.94-beta - Update interface to Langmuir parameterization
v0.95-beta - Add python 3 support

closes MPAS-Dev#250
mark-petersen added a commit to mark-petersen/MPAS-Model that referenced this pull request Jan 11, 2021
This version introduces a bunch of fixes to python 3

Releases since 0.84-beta are described as:

v0.90-beta - Add Schmittner tidal mixing
v0.91-beta - Add low-level interface for Bryan-Lewis mixing
v0.92-beta - Fix bug in computing derivative
v0.93-beta - Performance enhancement
v0.94-beta - Update interface to Langmuir parameterization
v0.95-beta - Add python 3 support

closes MPAS-Dev#250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants