Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh::load_vtk() always open files in binary mode #2654

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

jdtournier
Copy link
Member

Fix #2653.

@jdtournier jdtournier added the bug label Jun 13, 2023
@jdtournier jdtournier self-assigned this Jun 13, 2023
@jdtournier jdtournier requested review from Lestropie and a team and removed request for a team June 13, 2023 19:38
Copy link
Member

@Lestropie Lestropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and passes MSYS2 tests.
One small suggestion.
Should this instead (/ also) be going to master?

@jdtournier
Copy link
Member Author

Should this instead (/ also) be going to master?

Yes, I think it will need to. I've only worried about dev so far since this is what's blocking the compiler caching changes to the CI (#2624), but there's no doubt a recent build of master on a recent version of MSYS2 will also be affected. What I'm not sure about is whether the precompiled binaries we provide for MSYS2 would also be affected when running on a modern version of MSYS2 - it depends on whether the bug is in the system C/C++ dynamic libraries that MRtrix links to at runtime, or in the MRtrix package code generated by the compiler...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants