Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to separate out the
maf.summary
functions into smaller, modularized plotting functions. The need for this arose when I was trying to plot things using API data, but the API data is missing HGVSc and therefore I was not able to get any of the plots. I think this change is beneficial in general, as it allows users to be able to run only what they need. Also, it allows for easy customization syntax like this:A wrapper function called
maf_viz()
(feel free to change name of course) now exists that can call them all at once. It returns results in a list, as before.I also added a
utils.R
file with some functions that may be called in several places (e.g.check_maf_input()
)Here are a few outstanding questions/issues. Please let me know if you have any opinions:
p.variant.bp
,p.variant.dist
andp.variant.dist.bar
andp.snv.dist
to simplify the functions, as these may not be needed. We can discuss more in the meeting.p.corr
versusp.comut
. Is this just two ways to filter which genes are displayed? one shows top co-occuring genes and one shows correlations for overall top genes? If so, maybe we can put this in one function with an arg option? I may be misunderstanding this though.@arorarshi @AxelitoMartin