-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Formulaire signalement usager] Affichage des entreprises labellisées pour les territoires inactifs #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilschn
commented
Oct 3, 2023
hmeneuvrier
reviewed
Oct 4, 2023
Tests OK |
sfinx13
requested changes
Oct 5, 2023
emilschn
force-pushed
the
feature/352-entreprise-publique
branch
from
October 5, 2023 14:22
675cc15
to
37f79d1
Compare
tests OK |
hmeneuvrier
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est top ! Bien joué ! les tests sont ok aussi
sfinx13
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#352
Description
Contexte : Actuellement si un signalement est fait sur un territoire inactif, on lui envoie le protocole d'auto-traitement et rien d'autre.
Ce qu'on veut : On ajoute la possibilité d'accéder à la liste des entreprises labellisées dans le département de l'usager.
Changements apportés
Pré-requis
Le fichier csv est déjà sur le cloud
Pour info : il n'est pas complet, il manque certains départements. Ca ne bloque pas les tests.
Tests
make console app="get-entreprise-publique"
make load-migrations
make console app="import-entreprise-publique"
Tests de non-régression sur un territoire actif (ex : 13, 69)