Skip to content

Conversation

nekrich
Copy link
Member

@nekrich nekrich commented Jun 18, 2025

Pull Request Template

Description

Rename binary to the binary-dependencies-manager.
This reduces the tool configuration for mise from
"ubi:MacPaw/binary-dependencies-manager" = { version = "latest", exe = "BinaryDependenciesManager"}
to just
"ubi:MacPaw/binary-dependencies-manager" = "latest".

Because the default binary name is the GitHub repo basename.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

Additional Context

Add any other context or screenshots about the pull request here.

@nekrich nekrich requested a review from PaulTaykalo June 18, 2025 10:34
@@ -1,4 +1,4 @@
@testable import BinaryDependenciesManager
@testable import binary_dependencies_manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually make this CamelCased?
Product module is not the same. As binary/exectubale name

@nekrich nekrich merged commit 0f359b1 into main Jun 18, 2025
1 check passed
@nekrich nekrich deleted the chore/rename branch June 20, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants