-
Notifications
You must be signed in to change notification settings - Fork 15
MAINT: encrypt upload token directly in Appveyor UI #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8c44957
to
173a6c0
Compare
PRs now seem to be using the most recent appveyor webhook, which points to my own newly-created appveyor instance/project for |
* OPENBLAS_LIBS_STAGING_UPLOAD_TOKEN is now encrypted directly in the appveyor UI at: https://ci.appveyor.com/project/tylerjereddy/openblas-libs/settings/environment * this approach is used instead of pasting an encrypted env variable directly in the yml file, which seems to have stricter requirements in terms of ownership of the associated GitHub project
173a6c0
to
7fc3350
Compare
Updated to use |
Close/reopen after removing the webhook to Matthew's appveyor account, which was still taking precedence. |
The "pr" appveyor run is pointing to my appveyor accout, so that should upload. The "branch" run still points to Matthew's for whatever reason. |
All 14 release artifacts are visible at: https://anaconda.org/multibuild-wheels-staging/openblas-libs/files The Appveyor "pr" entry seems to behave as intended. The "branch" entry may be leftover from the old appveyor commit hook. Anyway, PRs from branches within the repo are likely to be the minority. The Travis CI "pr" entry also looks good. The Travis "push" entry can likely be ignored---I've not adjusted Travis here anyway. |
The github status display is still misleading because @matthew-brett's appveyor account is still active and probably overriding the MacPython/openblas-libs results. For instance: https://ci.appveyor.com/project/matthew-brett/openblas-libs/builds/31004859/job/gjlhcu2bb4gy0x0c that does not have access to the secret variable, has overridden: https://ci.appveyor.com/project/tylerjereddy/openblas-libs/builds/31004854/job/8iw5pusdtod3k0h4 which was successful. @matthew-brett could you please delete the https://ci.appveyor.com/project/matthew-brett/openblas-libs account now that @tylerjereddy's account works as expected? |
Deleted ...
…On Tue, Feb 25, 2020 at 9:20 AM Olivier Grisel ***@***.***> wrote:
The github status display are still misleading because @matthew-brett
<https://github.com/matthew-brett>'s appveyor account is still active and
probably overriding the MacPython/openblas-libs results.
For instance:
https://ci.appveyor.com/project/matthew-brett/openblas-libs/builds/31004859/job/gjlhcu2bb4gy0x0c
that does not have access to the secret variable, has overridden:
https://ci.appveyor.com/project/tylerjereddy/openblas-libs/builds/31004854/job/8iw5pusdtod3k0h4
which was successful.
@matthew-brett <https://github.com/matthew-brett> could you please delete
the https://ci.appveyor.com/project/matthew-brett/openblas-libs account
now that @tylerjereddy <https://github.com/tylerjereddy>'s account works
as expected?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AAAQQHBPOG6ZS257KVWEGMTRETPG3A5CNFSM4KYTGMM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM3F6BQ#issuecomment-590765830>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAQQHET6EDKU435JL32WMLRETPG3ANCNFSM4KYTGMMQ>
.
|
as a project "collaborator" & then open PR from a feature
branch within the repo proper, to see if this allows
accessing the secure token in Appveyor