Skip to content

update to macos-latest #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 20, 2025
Merged

update to macos-latest #210

merged 12 commits into from
Jul 20, 2025

Conversation

mattip
Copy link
Collaborator

@mattip mattip commented Jul 2, 2025

  • I updated the package version in pyproject.toml and made sure the first 3 numbers match git describe --tags --abbrev=8 in OpenBLAS at the OPENBLAS_COMMIT. If I did not update OPENBLAS_COMMIT, I incremented the wheel build number (i.e. 0.3.29.0.0 to 0.3.29.0.1)

This moves the macos builds from a x86_64 host to an arm64 host, hopefully it will Just Work

@mattip
Copy link
Collaborator Author

mattip commented Jul 19, 2025

CI is passing. It took a bit to work around limitations in the gfortran_install and multibuild subrepos, maybe we should switch to the scipy strategy of using the conda-forge compilers package instead

@rgommers
Copy link
Collaborator

Ah you switched all the builds to macos-latest; I had thought you'd leave the x86-64 builds on macos-13 because those are x86-64 runners. I have no idea if and when GitHub will deprecate those.

maybe we should switch to the scipy strategy of using the conda-forge compilers package instead

It's not a whole lot better (SDKROOT messing around still required), and actually it looks like for arm64 we're pulling in some other gfortran:

https://github.com/scipy/scipy/blob/9ae478ddaec6e1a71ca31624199e1ea171835eec/tools/wheels/cibw_before_build_macos.sh#L48

@rgommers
Copy link
Collaborator

The more impactful maintenance improvement is probably to switch to cibuildwheel

Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can only really know if this worked when building numpy/scipy wheels against these new versions, but the changes and CI logs LGTM.

@rgommers
Copy link
Collaborator

(I'll leave the merging up to you, since I didn't follow along very closely)

@mattip mattip merged commit 970cb75 into MacPython:main Jul 20, 2025
19 checks passed
@mattip
Copy link
Collaborator Author

mattip commented Jul 20, 2025

Thanks for the review

The more impactful maintenance improvement is probably to switch to cibuildwheel

Good idea, I will open an issue

@mattip mattip mentioned this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants