Algebraic Splines package #688
Conversation
This reverts commit 8c3e5df. Ready to update with latest version
Getting latest changes to M2 repository.
|
It would be good also to add the name of the package to the file containing the names of the packages to be distributed. See the README in the packages directory. |
|
Sorry about that. The distributed-packages file is now updated. |
| ------------------------------------------ | ||
| ------------------------------------------ | ||
|
|
||
| if version#"VERSION" <= "1.4" then ( |
There was a problem hiding this comment.
Compatibility with M2 1.4 seems no longer relevant.
| Headline => "Package for computing topological boundary maps and piecewise continuous splines on polyhedral complexes.", | ||
| Configuration => {}, | ||
| DebuggingMode => true, | ||
| if version#"VERSION" > "1.4" then PackageExports => { |
There was a problem hiding this comment.
Compatibility with M2 1.4 seems no longer relevant.
| } | ||
| ), x -> x =!= null) | ||
|
|
||
| if version#"VERSION" <= "1.4" then ( |
There was a problem hiding this comment.
Compatibility with M2 1.4 seems no longer relevant.
| }, | ||
| Headline => "Package for computing topological boundary maps and piecewise continuous splines on polyhedral complexes.", | ||
| Configuration => {}, | ||
| DebuggingMode => true, |
There was a problem hiding this comment.
Leave DebuggingMode false when distributing the package.
|
The examples run and the tests succeed, so that's good. |
| {Name => "Eliana Duarte", Email => "emduart2@illinois.edu", HomePage => "http://illinois.edu/~emduart2"}, | ||
| {Name => "Daniel Irving Bernstein", Email=> "dibernst@ncsu.edu", HomePage =>"http://www4.ncsu.edu/~dibernst"} | ||
| }, | ||
| Headline => "Package for computing topological boundary maps and piecewise continuous splines on polyhedral complexes.", |
There was a problem hiding this comment.
The prefix "Package for computing" seems redundant, since all packages are packages to compute something. Also, the headline would look better without the terminal period.
|
Okay, modulo those remarks, it looks good to me. |
…g mode, updated e-mails and websites
|
Ok, last pushed version addresses the above remarks. Thank you. |
|
Thank you for the contribution! |
I propose adding version 1.0 of the Algebraic Splines package to the Macaulay2 package repository. Programming for this package was begun at the 2015 Macaulay2 workshop in Boise by Michael DiPasquale, Gwyn Whieldon, Eliana Duarte, and Daniel Bernstein.