The bug has been fixed #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to add Miura.m2 to MaCaulay2/M2. You may think this code may be short but contains essence of ideal computation missed in the current M2. Thank you. Joe.
No error occured for installPackage "Miura" and check "Miura". Thank you. Joe.
I updated the file. Thank you. Joe.
This reverts commit 4d5a949.
This is the latest. Feel free to ask of this file.
I am sorry I did not know how to handle GitHub. Maybe this will be ok.
Please replace 0.1 with 0.2. Thank you. Joe.
I corrected two minor parts. Thank you,
|
Please base your PR on the most recent version of our master branch and resolve all the conflicts. Also make sure that |
|
Hi
I fixed all the warnings and errors by executing installPackage and check
for Miura.
Thank you for re-pull the revised version.
I believe this will satisfy the requirements.
Joe.
Joe Suzuki, Osaka, Japan
-------------------------------
joe@suzuki.email.ne.jp
2017-12-19 1:48 GMT+09:00 Daniel R. Grayson <notifications@github.com>:
… Please base your PR on the most recent version of our master branch and
resolve all the conflicts. Also make sure that installPackage "Miura" and check
"Miura" work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#721 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AH5RW-93E_hHpfRTPanjVo4HrU6UM8HFks5tBpdkgaJpZM4RFCpL>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dan.
Thank you very much.
I can ask pull request by virtue of you.
Joe.