Skip to content

Conversation

saihtaungkham
Copy link
Member

Fix Bugs

  • The Youtube query might not include "machine learning" keyword
  • Exclude the query result when video ID is null
  • Code Formatting

Features Added

  • Allow the client to specify the y_query_order for specific sorting on Youtube query result.
  • Add y_query_order in return Protocol Format as an optional attribute.

Copy link

@rhezaharliman rhezaharliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sai! Just trivial comments. Look goods for me.

@saihtaungkham
Copy link
Member Author

  • Fix YouTube API response. Now the user will be able to see only 10 results.

    • Remove y_next_page_token from response.
    • has_next_page = False by default
  • Improve Exception Handling Message.

  • Fix youtube into y in the cli arguments.

  • Now it is possible to apply multiple YouTube API keys with random sampling.

Copy link

@rhezaharliman rhezaharliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sai! Sorry for the late review. Please kindly find my comments. :)

Copy link
Member Author

@saihtaungkham saihtaungkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments. I made some reply. Please let me know if you have a better idea!

Copy link

@rhezaharliman rhezaharliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sai! Just one comment. If you don't think it's necessary, then it looks good to me. :)

@saihtaungkham
Copy link
Member Author

Thank you for your kind comments. I fixed it. Please check it out!

Copy link

@rhezaharliman rhezaharliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sai! Just one suggestion. Either way works for me. 😄

@saihtaungkham saihtaungkham merged commit 5a90bc6 into develop May 25, 2020
@saihtaungkham saihtaungkham deleted the fix/user_feedback branch May 25, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants