Fix/GitHub pagination #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix YouTube response result and Exceptions.
rhezaharliman
approved these changes
May 26, 2020
There was a problem hiding this comment.
Thanks, Sai! I haven't checked the behavior, but since the calculation also looks good, I think it'll be fine.
It'll be great though if the variable is easier to understand (or adds some documentation).
For example, item_per_page will be easier to understand rather than per_page. or firs_page_item_index, etc. It's just a matter of style.
|
I fixed the variable name and some code formatting is applied. Thanks for checking my formulae too. |
rhezaharliman
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the Github Pagination Logic.
Cherry Pick one fix from develop branch.