Skip to content

Make prepare() not use named statements by default when cache is disabled #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Make prepare() not use named statements by default when cache is disabled #1245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions asyncpg/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ async def _get_statement(
query,
timeout,
*,
named=False,
named: typing.Union[str, bool, None] = False,
use_cache=True,
ignore_custom_codec=False,
record_class=None
Expand Down Expand Up @@ -628,24 +628,25 @@ async def prepare(
query,
name=name,
timeout=timeout,
use_cache=False,
record_class=record_class,
)

async def _prepare(
self,
query,
*,
name=None,
name: typing.Union[str, bool, None] = None,
timeout=None,
use_cache: bool=False,
record_class=None
):
self._check_open()
if name is None:
name = self._stmt_cache_enabled
stmt = await self._get_statement(
query,
timeout,
named=True if name is None else name,
named=name,
use_cache=use_cache,
record_class=record_class,
)
Expand Down Expand Up @@ -1099,7 +1100,7 @@ async def copy_records_to_table(self, table_name, *, records,
intro_query = 'SELECT {cols} FROM {tab} LIMIT 1'.format(
tab=tabname, cols=col_list)

intro_ps = await self._prepare(intro_query, use_cache=True)
intro_ps = await self.prepare(intro_query)

cond = self._format_copy_where(where)
opts = '(FORMAT binary)'
Expand Down