Skip to content

Add return type to PoolAcquireContext.__aenter__ and rename attribute #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TerSent
Copy link

@TerSent TerSent commented Aug 16, 2025

Summary

Improves type inference in async with pool.acquire() by:

  1. Adding -> connection.Connection return type to PoolAcquireContext.__aenter__
  2. Renaming internal attribute self.connection to self._conn to avoid confusion and help type checkers

Motivation

Without this change, type checkers (mypy, pyright, pylance) cannot correctly infer the type of the connection in:

async with pool.acquire() as conn:
    await conn.fetchrow("SELECT 1")  # ← conn has type 'Unknown' or 'Any'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant