Skip to content

Commit

Permalink
Restore Python 3.5 support
Browse files Browse the repository at this point in the history
Fixes: #48
  • Loading branch information
elprans committed Feb 7, 2020
1 parent d4aa97b commit fce9310
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 6 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,14 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: [3.6, 3.7, 3.8]
python-version: [3.5, 3.6, 3.7, 3.8]
os: [ubuntu-16.04, macos-latest, windows-latest]
exclude:
# Python 3.5 is unable to properly
# find the recent VS tooling
# https://bugs.python.org/issue30389
- os: windows-latest
python-version: 3.5

steps:
- uses: actions/checkout@v1
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,14 @@ jobs:
strategy:
max-parallel: 4
matrix:
python-version: [3.6, 3.7, 3.8]
python-version: [3.5, 3.6, 3.7, 3.8]
os: [windows-latest, ubuntu-18.04, macos-latest]
exclude:
# Python 3.5 is unable to properly
# find the recent VS tooling
# https://bugs.python.org/issue30389
- os: windows-latest
python-version: 3.5

steps:
- uses: actions/checkout@v1
Expand Down
7 changes: 3 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,19 +116,18 @@ def build_extensions(self):
# Support macports on Mac OS X.
self.compiler.add_include_dir('/opt/local/include')
else:
self.compiler.add_include_dir(
os.path.join(ROOT, 'vendor/http-parser'))
self.compiler.add_include_dir(str(ROOT / 'vendor' / 'http-parser'))
self.distribution.ext_modules[0].sources.append(
'vendor/http-parser/http_parser.c')

super().build_extensions()


with open(os.path.join(ROOT, 'README.md')) as f:
with open(str(ROOT / 'README.md')) as f:
long_description = f.read()


with open(os.path.join(ROOT, 'httptools', '_version.py')) as f:
with open(str(ROOT / 'httptools' / '_version.py')) as f:
for line in f:
if line.startswith('__version__ ='):
_, _, version = line.partition('=')
Expand Down

0 comments on commit fce9310

Please sign in to comment.