Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.0 does not support Python 3.5 #48

Closed
untitaker opened this issue Feb 7, 2020 · 1 comment · Fixed by #49
Closed

0.1.0 does not support Python 3.5 #48

untitaker opened this issue Feb 7, 2020 · 1 comment · Fixed by #49

Comments

@untitaker
Copy link

I see no announcement in the changelog that support for 3.5 has been dropped. Was this intentional or not?

@BrandonTheBuilder
Copy link

When installing httptools on python 3.5 I get the following error -

    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/dl/7y8mkkj12v71xnv8rr2sgwb40000gn/T/pip-build-dp11b3qm/httptools/setup.py", line 127, in <module>
        with open(os.path.join(ROOT, 'README.md')) as f:
      File "/Users/larthur/.pyenv/versions/3.5.9/lib/python3.5/posixpath.py", line 89, in join
        genericpath._check_arg_types('join', a, *p)
      File "/Users/larthur/.pyenv/versions/3.5.9/lib/python3.5/genericpath.py", line 143, in _check_arg_types
        (funcname, s.__class__.__name__)) from None
    TypeError: join() argument must be str or bytes, not 'PosixPath'

This is because os.path.join and pathlib do not play nice together in python 3.5

elprans added a commit that referenced this issue Feb 7, 2020
elprans added a commit that referenced this issue Feb 7, 2020
elprans added a commit that referenced this issue Feb 7, 2020
Restore Python 3.5 support (#48).
@elprans elprans mentioned this issue Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants