Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_sockets.py::TestAIOSockets test timing out with 3.8.1 #318

Closed
doko42 opened this issue Feb 21, 2020 · 5 comments · Fixed by #372
Closed

test_sockets.py::TestAIOSockets test timing out with 3.8.1 #318

doko42 opened this issue Feb 21, 2020 · 5 comments · Fixed by #372
Labels
Projects

Comments

@doko42
Copy link

doko42 commented Feb 21, 2020

[forwarding from https://bugs.debian.org/950165]

test_sockets.py::TestAIOSockets tests are timing out with 3.8.1, see this change in all active Python branches: https://bugs.python.org/issue37228

@1st1
Copy link
Member

1st1 commented Feb 21, 2020

Thanks for creating this issue!

@1st1 1st1 added the bug label Feb 21, 2020
@1st1 1st1 added this to To do in v0.15 Mar 17, 2020
@fantix fantix moved this from To do to In progress in v0.15 May 9, 2020
@fantix
Copy link
Member

fantix commented May 9, 2020

Port of bpo-37228 is applied in #343, but this Debian bug is actually caused by bpo-30064, I think at the moment we could safely skip the hanging test tests.test_sockets.TestAIOSockets.test_sock_cancel_add_reader_race before there's a proper fix.

@fantix
Copy link
Member

fantix commented May 25, 2020

fixed in #346 and python/cpython#20369

@jonringer
Copy link

This is still an issue on python 3.8.3.

Trying to update nixpkgs package jonringer/nixpkgs@c7a6903 off of latest master, and test suite still hangs. Unfortunately I'm not sure what tests is hanging

@fantix
Copy link
Member

fantix commented Jun 24, 2020

right - sorry I think we should skip the whole Python 3.8 as the fix was only backported to 3.9. I'll create a PR for that.

fantix added a commit to fantix/uvloop that referenced this issue Dec 4, 2020
fantix added a commit that referenced this issue Dec 7, 2020
fantix added a commit that referenced this issue Dec 7, 2020
@1st1 1st1 closed this as completed in #372 Dec 7, 2020
1st1 pushed a commit that referenced this issue Dec 7, 2020
@fantix fantix moved this from In progress to Done in v0.15 Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
v0.15
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants