Restore context on listen in UVStreamServer. Fix #305 #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantix
requested changes
Mar 29, 2020
tests/test_context.py
Outdated
Comment on lines
165
to
166
| # Let all transports shutdown. | ||
| await asyncio.sleep(0.1) |
There was a problem hiding this comment.
Using sleep is generally not recommended for new tests in uvloop - this test is actually unstable, I could get a false OK if the srv.close() got called before the connection is fully established.
A proper fix is to use a Future, set in factory() and awaited in test() - we could even pass over the assertion error in this manner. With this fix, the ResourceWarning is also gone.
fantix
reviewed
Mar 30, 2020
fantix
reviewed
Mar 30, 2020
|
This particular fix is OK, but we need to fix this for all other "native" callbacks in uvloop in a more systematic way. |
fantix
pushed a commit
to fantix/uvloop
that referenced
this pull request
May 25, 2020
fantix
pushed a commit
to fantix/uvloop
that referenced
this pull request
Jan 21, 2021
fantix
pushed a commit
to fantix/uvloop
that referenced
this pull request
Jan 22, 2021
|
Merged in #348. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.