This repository was archived by the owner on Jul 8, 2023. It is now read-only.
fix remaining tiles counting when calling melds #107 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tenhou message, player from who the meld was called is encoded relative to the player who called the meld, not relative to the player to whom message is sent.
Nihisil
reviewed
Nov 23, 2018
| message = '<REINIT seed="0,0,1,4,3,59" ten="250,250,250,240" oya="0" ' \ | ||
| 'hai="1,2,4,13,17,20,46,47,53,71,76,81,85" ' \ | ||
| 'm2="41513" ' \ | ||
| 'm2="41515" ' \ |
There was a problem hiding this comment.
41513 был пример из реального лога, так что я думаю это не стоило менять. Возможно оно работало до этого так как хотела тенха :)
| meld.from_who = data & 0x3 | ||
| # 'from_who' is encoded relative the the 'who', so we want | ||
| # to convert it to be relative to our player | ||
| meld.from_who = ((data & 0x3) + meld.who) % 4 |
There was a problem hiding this comment.
Я взял код выше отсюда: https://github.com/NegativeMjark/tenhou-log/blob/master/TenhouDecoder.py#L38
У них же можешь посмотреть на формал мелда: https://github.com/NegativeMjark/tenhou-log#meld-format
|
Обсудили в тг, решили мержить. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.